file button: Don't leak rows
authorMatthias Clasen <mclasen@redhat.com>
Fri, 5 Jan 2018 16:09:04 +0000 (11:09 -0500)
committerMatthias Clasen <mclasen@redhat.com>
Fri, 5 Jan 2018 16:50:22 +0000 (11:50 -0500)
The file chooser button manually manages the memory of
data in its model, so it needs to explicitly free the
rows.

gtk/gtkfilechooserbutton.c

index 5168d40a4684164a83900d246f07d53e60f45c4c..06ebf0ff64253bf9f6e56dc518e39b07ce7936a4 100644 (file)
@@ -1041,7 +1041,10 @@ gtk_file_chooser_button_finalize (GObject *object)
     g_object_unref (priv->current_folder_while_inactive);
 
   if (priv->model)
-    g_object_unref (priv->model);
+    {
+      model_remove_rows (button, 0, gtk_tree_model_iter_n_children (priv->model, NULL));
+      g_object_unref (priv->model);
+    }
 
   gtk_widget_unparent (priv->button);
   gtk_widget_unparent (priv->combo_box);